Skip to content

Fix Link to std::ptr::null #24432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

killercup
Copy link
Member

The "Primitive Type pointer" docs link to std/fn.null.html which does not exist.

This changes to link to std/ptr/fn.null.html.

@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

Oh dear this is unfortunate, it's valid on the std::ptr docs page but not valid on the primitive.ptr.html page. Perhaps the link could just be removed for now?

@killercup
Copy link
Member Author

Oh, it's the same source for both pages? That'll be really tricky to solve.

I'll just remove it for now.

On Tue, Apr 14, 2015 at 11:13 PM, Alex Crichton [email protected]
wrote:

Oh dear this is unfortunate, it's valid on the std::ptr docs page but not valid on the primitive.ptr.html page. Perhaps the link could just be removed for now?

Reply to this email directly or view it on GitHub:
#24432 (comment)

@killercup
Copy link
Member Author

(I'll create a new PR for that as I currently only have access to Github's web interface for changes.)

@killercup killercup closed this Apr 14, 2015
Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 15, 2015
The link works on the `std/ptr/index.html` docs page, but not the `std/primitive.pointer.html` page. Instead of leaving it half-broken, it is removed.

I tried fixing this in rust-lang#24432, but @alexcrichton mentioned that this doc string was used in two places (with different base paths unfortunately).

r? @alexcrichton
Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 15, 2015
The link works on the `std/ptr/index.html` docs page, but not the `std/primitive.pointer.html` page. Instead of leaving it half-broken, it is removed.

I tried fixing this in rust-lang#24432, but @alexcrichton mentioned that this doc string was used in two places (with different base paths unfortunately).

r? @alexcrichton
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Apr 15, 2015
The link works on the `std/ptr/index.html` docs page, but not the `std/primitive.pointer.html` page. Instead of leaving it half-broken, it is removed.

I tried fixing this in rust-lang#24432, but @alexcrichton mentioned that this doc string was used in two places (with different base paths unfortunately).

r? @alexcrichton
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants